[gephex-devel] optimisation is to optimistic

[Martin Bayer]

-> moved to devel

> And add all nonstatic modules and all modules in a cycle to the set of
> "sinks".

--- orig/engine/src/renderer/runtimesystem.cpp
+++ mod/engine/src/renderer/runtimesystem.cpp
@@ -286,11 +286,12 @@
      ModuleControlBlockPtr newBlock ( new ModuleControlBlock(newModule) );

      m_modules[moduleID] = newBlock;
-
-    // no output => module is a sink
-    if (newModule->getOutputs().size() == 0)
+
+    // no output or notdeterministic => module is a sink
+    if (( newModule->getOutputs().size() == 0 ) ||
+       ( !newModule->isDeterministic()) )
        m_sinks.push_front(newBlock);
-
+
  #if (ENGINE_VERBOSITY > 0)
      std::cout << "Added new Module (id " << moduleID << ") of Class "
               << moduleClassName << std::endl;


The cycle test could be added before the graph update. I don't think we
need the cycle test for 0.4. But in 0.5 all deterministic subgraphs will
have cycles.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.gephex.org/pipermail/gephex-devel/attachments/20050303/0d6e1605/signature.pgp