[gephex-devel] effectv pplugins

[Georg Seidel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sven,

> Is there any interest in this work to be done? Any Opinions?

I just had another look at the code, and one small issue came to my 
mind.
You use the globalvariables g_animate_focus, g_focus_interval, ...
to tell spiral.c the input values of the gephex inputs.
However, if there are multiple instances of the effectvspiralmodule,
the way you do it may cause problems.

Imagine there are two instances.
Then it might happen that one has changed the global variable
g_animate_focus, but the other one does not know. And the check

    if(inst->in_animate_focus->number != my->old_animate_focus) {
	g_animate_focus = (int)inst->in_animate_focus->number;
	my->old_animate_focus = inst->in_animate_focus->number;
     }

does not detect it.

To be safe it would be best to always set g_animate_focus, I think.
Alternatively you could use the event function and translate changes
of the inputs into SDL events (IIRC lensmodule does it that way).

Best regards,

Georg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iD8DBQFCBoyN/rP0cdKF/ToRAj2BAJ9Bqq1ULX2SIUq2+9zrAZo7AyVzMQCfULvS
p9zbG5mnc7a5noRjk5JluKQ=
=XZ8Z
-----END PGP SIGNATURE-----